Riza Suminto has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22453 )

Change subject: IMPALA-13736: Fix Use-After-Free in ExecutorGroup.RemoveExecutor
......................................................................


Patch Set 3: Code-Review+2

(2 comments)

http://gerrit.cloudera.org:8080/#/c/22453/1/be/src/scheduling/executor-group.cc
File be/src/scheduling/executor-group.cc:

http://gerrit.cloudera.org:8080/#/c/22453/1/be/src/scheduling/executor-group.cc@159
PS1, Line 159:   const int64_t be_admin_mem
> I tried moving this statement around but ran into a couple different proble
Ack


http://gerrit.cloudera.org:8080/#/c/22453/1/be/src/scheduling/executor-group.cc@164
PS1, Line 164: lculatePerExecut
> see previous comment
Ack



--
To view, visit http://gerrit.cloudera.org:8080/22453
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If14a3c89ee631ebb05efc9a47745f7e63ab98690
Gerrit-Change-Number: 22453
Gerrit-PatchSet: 3
Gerrit-Owner: Jason Fehr <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Jason Fehr <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Comment-Date: Thu, 06 Feb 2025 19:07:59 +0000
Gerrit-HasComments: Yes

Reply via email to