Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21851 )
Change subject: IMPALA-13389: Refactor all webUI JS to use ES6 syntax ...................................................................... Patch Set 5: (2 comments) Please rebase and I'll re-review this. http://gerrit.cloudera.org:8080/#/c/21851/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21851/5//COMMIT_MSG@30 PS5, Line 30: With this naming scheme, : -> All functions have been declared using camel case. : -> All constant primitive values and strings are declared in uppercase. : -> All general and local variables have been renamed to use underscores : instead of camel case. > Is this naming scheme changes required by ES6 standard? On second thought, I don't mind doing the renames along in this patch. http://gerrit.cloudera.org:8080/#/c/21851/5/www/admission_controller.tmpl File www/admission_controller.tmpl: http://gerrit.cloudera.org:8080/#/c/21851/5/www/admission_controller.tmpl@149 PS5, Line 149: const POOL_NAME = json[pool_idx]['pool_name']; : const histogram = json[pool_idx]["peak_mem_usage_histogram"]; > Why one constant is uppercase and the other constant is lower case? Ok, you mentioned the reason in commit message. Although I'm not sure what the significance is, and how it it will be enforced for future contributors. -> All constant primitive values and strings are declared in uppercase. -- To view, visit http://gerrit.cloudera.org:8080/21851 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie38f2c642ede14956a2c6d551a58e42538204768 Gerrit-Change-Number: 21851 Gerrit-PatchSet: 5 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Fri, 07 Feb 2025 18:02:01 +0000 Gerrit-HasComments: Yes
