Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21851 )
Change subject: IMPALA-13389: Refactor webUI scripts to use ES6 syntax ...................................................................... Patch Set 6: (2 comments) Gerrit still says there is a merge conflict at ps6. Please rebase again. http://gerrit.cloudera.org:8080/#/c/21851/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21851/5//COMMIT_MSG@30 PS5, Line 30: in uppercase. : -> All other types of variables have been declared using snake case. : : This naming scheme allows easier distinction between functions, : constants and other varia > I can pre-enforce the rules from IMPALA-13473 to match here or switch the o Lets merge this first ahead of IMPALA-13473. Done. http://gerrit.cloudera.org:8080/#/c/21851/6/www/query_finstances.tmpl File www/query_finstances.tmpl: http://gerrit.cloudera.org:8080/#/c/21851/6/www/query_finstances.tmpl@107 PS6, Line 107: if (toggle.checked === true) { : interval_id = setInterval(refresh, 1000); : document.getElementById("refresh_on").textContent = "Auto-refresh on"; Can you elaborate in commit message why this some getElementById() is gone and some stay? Here, getElementById("toggle") changed, but getElementById("refresh_on") stays. What is the difference? -- To view, visit http://gerrit.cloudera.org:8080/21851 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie38f2c642ede14956a2c6d551a58e42538204768 Gerrit-Change-Number: 21851 Gerrit-PatchSet: 6 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Fri, 07 Feb 2025 20:23:07 +0000 Gerrit-HasComments: Yes
