Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/22197 )
Change subject: IMPALA-13599: Reduce the number of interactions with alter_partition() HMS API ...................................................................... Patch Set 4: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/22197/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22197/4//COMMIT_MSG@13 PS4, Line 13: only once regardless : of number of partitions. : nit: We have a limit of 500 partitions per HMS RPC in bulkAlterPartitions(): MAX_PARTITION_UPDATES_PER_RPC = 500; https://github.com/apache/impala/blob/856741b1e8371b983da10f23a166f19aac71f1f8/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java#L6892-L6894 http://gerrit.cloudera.org:8080/#/c/22197/4//COMMIT_MSG@18 PS4, Line 18: single nit: so we will generate around #partitions/500 events. -- To view, visit http://gerrit.cloudera.org:8080/22197 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2f2f1d9637e8be9c931da0415a17dd0839637e4c Gerrit-Change-Number: 22197 Gerrit-PatchSet: 4 Gerrit-Owner: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Mon, 10 Feb 2025 23:26:38 +0000 Gerrit-HasComments: Yes
