Gabriella Gyorgyevics has posted comments on this change. ( http://gerrit.cloudera.org:8080/22165 )
Change subject: IMPALA-13648: Implement a decoder and an encoder for Byte Stream Split encoding ...................................................................... Patch Set 27: (2 comments) http://gerrit.cloudera.org:8080/#/c/22165/27/be/src/exec/parquet/parquet-byte-stream-split-encoder.cc File be/src/exec/parquet/parquet-byte-stream-split-encoder.cc: http://gerrit.cloudera.org:8080/#/c/22165/27/be/src/exec/parquet/parquet-byte-stream-split-encoder.cc@49 PS27, Line 49: if(output_buffer_ == nullptr) { return false; } > Nit: leave a space after "if". Done http://gerrit.cloudera.org:8080/#/c/22165/27/be/src/exec/parquet/parquet-byte-stream-split-test.cc File be/src/exec/parquet/parquet-byte-stream-split-test.cc: http://gerrit.cloudera.org:8080/#/c/22165/27/be/src/exec/parquet/parquet-byte-stream-split-test.cc@46 PS27, Line 46: return ParquetByteStreamSplitEncoder<T_SIZE>(); > We could also add "EXPECT_EQ(byte_size, T_SIZE)" here. Done -- To view, visit http://gerrit.cloudera.org:8080/22165 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icea60894ae22b8ddb7616aeda6d69012cc69972c Gerrit-Change-Number: 22165 Gerrit-PatchSet: 27 Gerrit-Owner: Gabriella Gyorgyevics <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Gabriella Gyorgyevics <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Comment-Date: Tue, 11 Feb 2025 10:17:22 +0000 Gerrit-HasComments: Yes
