Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22475 )
Change subject: [PROTOTYPE] IMPALA-13653: Create hooks for Calcite planner in Frontend ...................................................................... Patch Set 1: (6 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22475/1/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/22475/1/fe/src/main/java/org/apache/impala/service/Frontend.java@2012 PS1, Line 2012: // TODO: Rethink how this gets passed out. It would be cleaner if this function returned line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/22475/1/fe/src/main/java/org/apache/impala/service/FrontendImplFactory.java File fe/src/main/java/org/apache/impala/service/FrontendImplFactory.java: http://gerrit.cloudera.org:8080/#/c/22475/1/fe/src/main/java/org/apache/impala/service/FrontendImplFactory.java@40 PS1, Line 40: // TODO: Maybe this is easier as an abstract class so this overload calls the other one. line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/22475/1/fe/src/test/java/org/apache/impala/common/FrontendFixture.java File fe/src/test/java/org/apache/impala/common/FrontendFixture.java: http://gerrit.cloudera.org:8080/#/c/22475/1/fe/src/test/java/org/apache/impala/common/FrontendFixture.java@367 PS1, Line 367: ParsedStatement parsedStmt = new ParsedStatementImpl(Parser.parse(stmt, ctx.getQueryOptions())); line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/22475/1/fe/src/test/java/org/apache/impala/common/FrontendTestBase.java File fe/src/test/java/org/apache/impala/common/FrontendTestBase.java: http://gerrit.cloudera.org:8080/#/c/22475/1/fe/src/test/java/org/apache/impala/common/FrontendTestBase.java@348 PS1, Line 348: ParsedStatement parsedStmt = new ParsedStatementImpl(Parser.parse(stmt, ctx.getQueryOptions())); line too long (102 > 90) http://gerrit.cloudera.org:8080/#/c/22475/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteAnalysisContext.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteAnalysisContext.java: http://gerrit.cloudera.org:8080/#/c/22475/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteAnalysisContext.java@104 PS1, Line 104: analysisResult.reader_ = CalciteMetadataHandler.createCalciteCatalogReader(stmtTableCache, line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/22475/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteSingleNodePlanner.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteSingleNodePlanner.java: http://gerrit.cloudera.org:8080/#/c/22475/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteSingleNodePlanner.java@50 PS1, Line 50: protected static final Logger LOG = LoggerFactory.getLogger(CalciteSingleNodePlanner.class.getName()); line too long (104 > 90) -- To view, visit http://gerrit.cloudera.org:8080/22475 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I62a1e669b7a7b2e7cfdf3edafa59942fe06fd825 Gerrit-Change-Number: 22475 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Tue, 11 Feb 2025 23:53:46 +0000 Gerrit-HasComments: Yes
