Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/22477 )
Change subject: IMPALA-13728: OpenSSLUtilTest.ValidateInitialize failed by AES_128_GCM not supported ...................................................................... Patch Set 1: Code-Review+1 (2 comments) Thanks for fixing this! http://gerrit.cloudera.org:8080/#/c/22477/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22477/1//COMMIT_MSG@10 PS1, Line 10: the mentioned OpenSSL version What is that version? Instead, we could say "not supported in all OpenSSL versions". Also at the end of the commit message. http://gerrit.cloudera.org:8080/#/c/22477/1/be/src/util/openssl-util-test.cc File be/src/util/openssl-util-test.cc: http://gerrit.cloudera.org:8080/#/c/22477/1/be/src/util/openssl-util-test.cc@148 PS1, Line 148: its Nit: it's. -- To view, visit http://gerrit.cloudera.org:8080/22477 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If5b3a000e302d2705a02820c560b474f0c311560 Gerrit-Change-Number: 22477 Gerrit-PatchSet: 1 Gerrit-Owner: Pranav Lodha <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Wed, 12 Feb 2025 12:32:14 +0000 Gerrit-HasComments: Yes
