Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10480 )
Change subject: Upgrade Protobuf to 3.5.1 ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10480/1/buildall.sh File buildall.sh: http://gerrit.cloudera.org:8080/#/c/10480/1/buildall.sh@97 PS1, Line 97: if (( BUILD_HISTORICAL )) ; then > Just following the pattern of BUILD_HISTORICAL for other components here. S Let's do the cleanup in a separate change, and maybe once we retire the 2.x branch. Until then we might need cherry picks in the toolchain repo and those will see more conflicts if we remove all the old versions. We don't build with BUILD_HISTORICAL when publishing bits, either, so there's no overhead in keeping them. -- To view, visit http://gerrit.cloudera.org:8080/10480 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4e4e9dc301ff16f9aecc32d30c22b523dda3033c Gerrit-Change-Number: 10480 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Comment-Date: Thu, 24 May 2018 18:22:21 +0000 Gerrit-HasComments: Yes
