Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/22438 )
Change subject: IMPALA-13724: Add hostnames for Docker host and gateway to Impala containers ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/22438/1/bin/start-impala-cluster.py File bin/start-impala-cluster.py: http://gerrit.cloudera.org:8080/#/c/22438/1/bin/start-impala-cluster.py@1021 PS1, Line 1021: internal_listen_host = os.environ["INTERNAL_LISTEN_HOST"] > Joe once gave me similar review, and I like it very much, because it gather Oh, I completely agree on how configurability should be set up, that wasn't really my question, I'm sorry. What I really wanted to ask was why you would like to configure the hostname that we set for the internal gateway. AFAICT this is used only during Thrift connection setup (mostly during logging); it doesn't really appear anywhere else. I'm not against the suggestion, you just made me wonder about the use case you had in mind. -- To view, visit http://gerrit.cloudera.org:8080/22438 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I545607c0bb32f8043a0d3f6045710f28a47bab99 Gerrit-Change-Number: 22438 Gerrit-PatchSet: 1 Gerrit-Owner: Laszlo Gaal <laszlo.g...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Laszlo Gaal <laszlo.g...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Wed, 12 Feb 2025 18:06:03 +0000 Gerrit-HasComments: Yes
