Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/22458 )
Change subject: IMPALA-13737: Directly load file metadata via IcebergFileMetadataLoader ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/22458/2/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/22458/2/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@246 PS2, Line 246: Whether to skip file metadata loading. (only used when HdfsTable is part of : // an Iceberg table > I didn't mean changing the constructor but adding an overloaded one. Would The current constructor is quite minimal: HdfsTable(org.apache.hadoop.hive.metastore.api.Table msTbl, Db db, String name, String owner) I'd rather not add an overload just for this, as someone might start using that and we plan to remove this flag anyway. Moreover, this class already has a few setters. -- To view, visit http://gerrit.cloudera.org:8080/22458 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaf7e23ec21b65036b47edadcb4cbe4b64be3baee Gerrit-Change-Number: 22458 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 13 Feb 2025 16:22:38 +0000 Gerrit-HasComments: Yes
