Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10504 )
Change subject: IMPALA-7068: fix test_unsupported_text_compression table location ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10504/1/tests/metadata/test_partition_metadata.py File tests/metadata/test_partition_metadata.py: http://gerrit.cloudera.org:8080/#/c/10504/1/tests/metadata/test_partition_metadata.py@168 PS1, Line 168: TBL_LOCATION = '%s/%s.db/%s' % (WAREHOUSE, unique_database, TBL_NAME) > Is there a way we could detect this mistake or avoid it? E.g. make get_fs_p I was going to add an assert, but making it idempotent is even better. In any case, will do in a separate commit after builds are green again. -- To view, visit http://gerrit.cloudera.org:8080/10504 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I73f21866d5c2bd7d3f4a5110d4d088a718b56960 Gerrit-Change-Number: 10504 Gerrit-PatchSet: 1 Gerrit-Owner: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 24 May 2018 20:38:44 +0000 Gerrit-HasComments: Yes
