Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22488 )
Change subject: IMPALA-13752: Remove option value quoting in __restore_query_options ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/22488/3/tests/common/impala_connection.py File tests/common/impala_connection.py: http://gerrit.cloudera.org:8080/#/c/22488/3/tests/common/impala_connection.py@78 PS3, Line 78: if not val: : # Value is optional with None as default. : val = '""' This correctly handles optional query option without any default value. -- To view, visit http://gerrit.cloudera.org:8080/22488 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I004ca021f64ffcc0c3d4cb2bb4aa550012b1be20 Gerrit-Change-Number: 22488 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Tue, 18 Feb 2025 16:24:45 +0000 Gerrit-HasComments: Yes
