Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22503 )
Change subject: IMPALA-13771: Fix heap-use-after-free in Cluster Membership Manager ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/22503/2/be/src/scheduling/cluster-membership-mgr.cc File be/src/scheduling/cluster-membership-mgr.cc: http://gerrit.cloudera.org:8080/#/c/22503/2/be/src/scheduling/cluster-membership-mgr.cc@303 PS2, Line 303: nit: extra whitespace http://gerrit.cloudera.org:8080/#/c/22503/2/be/src/scheduling/cluster-membership-mgr.cc@309 PS2, Line 309: new_backend_map->erase(item.key); Can we add a comment here about it invalidating be_desc? -- To view, visit http://gerrit.cloudera.org:8080/22503 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4fd2c9faa6daba9274f38238b952c377a07794e9 Gerrit-Change-Number: 22503 Gerrit-PatchSet: 2 Gerrit-Owner: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Wed, 19 Feb 2025 21:59:09 +0000 Gerrit-HasComments: Yes
