Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22411 )
Change subject: IMPALA-13716: Calcite Planner: TupleIsNullPredicate fix for analytic functions ...................................................................... Patch Set 5: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/22411/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaAnalyticRel.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaAnalyticRel.java: http://gerrit.cloudera.org:8080/#/c/22411/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaAnalyticRel.java@152 PS5, Line 152: tupleIsNullPreds); > Ok, so that is a really good question. I also find the expression substitution maps a bit difficult to reason about. So I think this is ok for now. -- To view, visit http://gerrit.cloudera.org:8080/22411 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaec363c2fa93a1e21bf74a40e5399e21ddd9bd60 Gerrit-Change-Number: 22411 Gerrit-PatchSet: 5 Gerrit-Owner: Steve Carlin <scar...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Steve Carlin <scar...@cloudera.com> Gerrit-Comment-Date: Thu, 20 Feb 2025 00:51:31 +0000 Gerrit-HasComments: Yes
