Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22511 )
Change subject: IMPALA-13772: Fix Workload Management DMLs Time Out After 10 Seconds ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/22511/2/be/src/service/workload-management-worker.cc File be/src/service/workload-management-worker.cc: http://gerrit.cloudera.org:8080/#/c/22511/2/be/src/service/workload-management-worker.cc@776 PS2, Line 776: opts[TImpalaQueryOptions::FETCH_ROWS_TIMEOUT_MS] = "0"; Is it better to set very high number? 30 minutes perhaps? http://gerrit.cloudera.org:8080/#/c/22511/2/tests/custom_cluster/test_admission_controller.py File tests/custom_cluster/test_admission_controller.py: http://gerrit.cloudera.org:8080/#/c/22511/2/tests/custom_cluster/test_admission_controller.py@a149 PS2, Line 149: Where is this function moved to? I don't see tests/common/admission_control.py. http://gerrit.cloudera.org:8080/#/c/22511/2/tests/custom_cluster/test_query_log.py File tests/custom_cluster/test_query_log.py: http://gerrit.cloudera.org:8080/#/c/22511/2/tests/custom_cluster/test_query_log.py@424 PS2, Line 424: QUERY_TBL Maybe rename this to distinguish from QUERY_TBL from L42? -- To view, visit http://gerrit.cloudera.org:8080/22511 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0cc7fbce40eadfb253d8cff5cbb83e2ad63a979f Gerrit-Change-Number: 22511 Gerrit-PatchSet: 2 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 20 Feb 2025 22:48:43 +0000 Gerrit-HasComments: Yes
