Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22306 )
Change subject: IMPALA-13653: Create hooks for Calcite planner in Frontend ...................................................................... Patch Set 10: (4 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22306/10/fe/src/main/java/org/apache/impala/service/CompilerFactory.java File fe/src/main/java/org/apache/impala/service/CompilerFactory.java: http://gerrit.cloudera.org:8080/#/c/22306/10/fe/src/main/java/org/apache/impala/service/CompilerFactory.java@44 PS10, Line 44: public AnalysisDriver createAnalysisDriver(AnalysisContext ctx) throws AnalysisException; line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/22306/10/fe/src/main/java/org/apache/impala/service/CompilerFactoryImpl.java File fe/src/main/java/org/apache/impala/service/CompilerFactoryImpl.java: http://gerrit.cloudera.org:8080/#/c/22306/10/fe/src/main/java/org/apache/impala/service/CompilerFactoryImpl.java@41 PS10, Line 41: public ParsedStatement createParsedStatement(TQueryCtx queryCtx) throws ImpalaException { line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/22306/10/fe/src/main/java/org/apache/impala/service/CompilerFactoryImpl.java@45 PS10, Line 45: public AnalysisDriver createAnalysisDriver(AnalysisContext ctx) throws AnalysisException { line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/22306/10/fe/src/test/java/org/apache/impala/common/FrontendTestBase.java File fe/src/test/java/org/apache/impala/common/FrontendTestBase.java: http://gerrit.cloudera.org:8080/#/c/22306/10/fe/src/test/java/org/apache/impala/common/FrontendTestBase.java@356 PS10, Line 356: ParsedStatement parsedStmt = compilerFactory.createParsedStatement(ctx.getQueryCtx()); line too long (92 > 90) -- To view, visit http://gerrit.cloudera.org:8080/22306 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I978aa48b160984ee5d36244cd915940f838d141d Gerrit-Change-Number: 22306 Gerrit-PatchSet: 10 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Fri, 21 Feb 2025 00:26:04 +0000 Gerrit-HasComments: Yes
