Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20440 )
Change subject: POC local partitioned join ...................................................................... Patch Set 4: (4 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/20440/4/be/src/runtime/krpc-data-stream-sender.cc File be/src/runtime/krpc-data-stream-sender.cc: http://gerrit.cloudera.org:8080/#/c/20440/4/be/src/runtime/krpc-data-stream-sender.cc@109 PS4, Line 109: address_to_channels[destinations[i].krpc_backend().SerializeAsString()].push_back(i); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/20440/4/be/src/runtime/krpc-data-stream-sender.cc@121 PS4, Line 121: && key_val.first != ExecEnv::GetInstance()->krpc_address().SerializeAsString()) { line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/20440/4/fe/src/main/java/org/apache/impala/planner/DataPartition.java File fe/src/main/java/org/apache/impala/planner/DataPartition.java: http://gerrit.cloudera.org:8080/#/c/20440/4/fe/src/main/java/org/apache/impala/planner/DataPartition.java@86 PS4, Line 86: return new DataPartition(TPartitionType.KUDU, Lists.newArrayList(expr), line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/20440/4/tests/query_test/test_join_queries.py File tests/query_test/test_join_queries.py: http://gerrit.cloudera.org:8080/#/c/20440/4/tests/query_test/test_join_queries.py@75 PS4, Line 75: = flake8: E225 missing whitespace around operator -- To view, visit http://gerrit.cloudera.org:8080/20440 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I05780343c788c12f345992066091e0e7813028f5 Gerrit-Change-Number: 20440 Gerrit-PatchSet: 4 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Fri, 21 Feb 2025 13:20:29 +0000 Gerrit-HasComments: Yes
