Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/22511 )
Change subject: IMPALA-13772: Fix Workload Management DMLs Timeouts ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/22511/2/be/src/service/workload-management-worker.cc File be/src/service/workload-management-worker.cc: http://gerrit.cloudera.org:8080/#/c/22511/2/be/src/service/workload-management-worker.cc@776 PS2, Line 776: opts[TImpalaQueryOptions::STATEMENT_EXPRESSION_LIMIT] = > Is it better to set very high number? 30 minutes perhaps? Other timeouts will kick in to prevent the query from waiting too long. Specifically, the 'impala.admission-control.pool-queue-timeout-ms' setting in llama-site.xml defines the max amount of time any query will wait in the admission control queue. This timeout will kick in to prevent the insert DML from waiting too long. However, there is no timeout that forces query execution to give up. I added that query option as well. http://gerrit.cloudera.org:8080/#/c/22511/2/tests/custom_cluster/test_admission_controller.py File tests/custom_cluster/test_admission_controller.py: http://gerrit.cloudera.org:8080/#/c/22511/2/tests/custom_cluster/test_admission_controller.py@a149 PS2, Line 149: > Where is this function moved to? I don't see tests/common/admission_control Forgot to check in the new file I added. http://gerrit.cloudera.org:8080/#/c/22511/2/tests/custom_cluster/test_query_log.py File tests/custom_cluster/test_query_log.py: http://gerrit.cloudera.org:8080/#/c/22511/2/tests/custom_cluster/test_query_log.py@424 PS2, Line 424: @classmet > Maybe rename this to distinguish from QUERY_TBL from L42? Actually, since the workload management initialization is now done in the catalog, this variable is not needed at all since it is no longer used in the TestQueryLogTableBase setup_method. -- To view, visit http://gerrit.cloudera.org:8080/22511 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0cc7fbce40eadfb253d8cff5cbb83e2ad63a979f Gerrit-Change-Number: 22511 Gerrit-PatchSet: 5 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Fri, 21 Feb 2025 17:16:18 +0000 Gerrit-HasComments: Yes
