Jason Fehr has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22447 )

Change subject:     IMPALA-4017: support ANSI timestamp literal cast
......................................................................


Patch Set 3:

Looks like a good start.  Please add tests that demonstrate this new TIMESTAMP 
keyword.  See 
https://github.com/apache/impala/tree/master/testdata/workloads/functional-query/queries/QueryTest
 for examples of how to add these types of tests.


--
To view, visit http://gerrit.cloudera.org:8080/22447
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibcfd219c0a3192b2e2ea9a9363636f6194df8174
Gerrit-Change-Number: 22447
Gerrit-PatchSet: 3
Gerrit-Owner: Anshula Jain <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Jason Fehr <[email protected]>
Gerrit-Comment-Date: Fri, 21 Feb 2025 22:48:39 +0000
Gerrit-HasComments: No

Reply via email to