Daniel Becker has uploaded this change for review. (
http://gerrit.cloudera.org:8080/22522
Change subject: IMPALA-13770 (Addendum): Close expressions in
IcebergMergeCasePlan
......................................................................
IMPALA-13770 (Addendum): Close expressions in IcebergMergeCasePlan
IMPALA-13770 added code to call Close() on
IcebergMergeCase::{output_exprs_,filter_conjuncts_}. However, these
expressions are created by IcebergMergeCasePlan, with pointers to the
expressions copied to possibly multiple IcebergMergeCase objects.
Therefore, although it does not cause errors in practice, it is better
to close the expressions in IcebergMergeCasePlan.
This change adds a Close() method to IcebergMergeCasePlan that closes
these expressions.
This patch also calls Close() on IcebergMergeSinkConfig::merge_action_
and IcebergMergeSink::merge_action_evaluator_, which were not closed
previously.
Change-Id: Iefa998dea173051702ef08c03b489178a17a653f
---
M be/src/exec/iceberg-merge-node.cc
M be/src/exec/iceberg-merge-node.h
M be/src/exec/iceberg-merge-sink.cc
3 files changed, 16 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/22/22522/2
--
To view, visit http://gerrit.cloudera.org:8080/22522
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iefa998dea173051702ef08c03b489178a17a653f
Gerrit-Change-Number: 22522
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Becker <[email protected]>
