Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22280 )

Change subject: IMPALA-13566: Expose query cancellation status to UDFs
......................................................................


Patch Set 7:

(7 comments)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/22280/7/tests/common/impala_connection.py
File tests/common/impala_connection.py:

http://gerrit.cloudera.org:8080/#/c/22280/7/tests/common/impala_connection.py@694
PS7, Line 694: s
flake8: U100 Unused argument 'sql_stmt'


http://gerrit.cloudera.org:8080/#/c/22280/7/tests/common/impala_connection.py@706
PS7, Line 706: s
flake8: U100 Unused argument 'sql_stmt'


http://gerrit.cloudera.org:8080/#/c/22280/7/tests/common/impala_connection.py@754
PS7, Line 754: n
flake8: U100 Unused argument 'name'


http://gerrit.cloudera.org:8080/#/c/22280/7/tests/common/impala_connection.py@754
PS7, Line 754: v
flake8: U100 Unused argument 'value'


http://gerrit.cloudera.org:8080/#/c/22280/7/tests/common/impala_connection.py@769
PS7, Line 769: o
flake8: U100 Unused argument 'operation_handle'


http://gerrit.cloudera.org:8080/#/c/22280/7/tests/common/impala_connection.py@772
PS7, Line 772: o
flake8: U100 Unused argument 'operation_handle'


http://gerrit.cloudera.org:8080/#/c/22280/7/tests/common/impala_connection.py@772
PS7, Line 772: m
flake8: U100 Unused argument 'message'



--
To view, visit http://gerrit.cloudera.org:8080/22280
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9430167f7e46bbdf66153abb4645541cd8cf0142
Gerrit-Change-Number: 22280
Gerrit-PatchSet: 7
Gerrit-Owner: Xuebin Su <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Surya Hebbar <[email protected]>
Gerrit-Comment-Date: Tue, 25 Feb 2025 06:23:23 +0000
Gerrit-HasComments: Yes

Reply via email to