Anonymous Coward (816) has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22413 )

Change subject: IMPALA-13717: Calcite Planner, enable UTF-8 character set
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/22413/5/java/calcite-planner/src/main/codegen/templates/Parser.jj
File java/calcite-planner/src/main/codegen/templates/Parser.jj:

http://gerrit.cloudera.org:8080/#/c/22413/5/java/calcite-planner/src/main/codegen/templates/Parser.jj@4480
PS5, Line 4480: String charSet = "UTF8";
> Not sure what that is. Can you explain or provide a resource?
e.g. 
https://github.com/apache/drill/blob/master/exec/java-exec/src/test/resources/saffron.properties



--
To view, visit http://gerrit.cloudera.org:8080/22413
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f4a01a28aa673fbd9239177accaec182f0972b0
Gerrit-Change-Number: 22413
Gerrit-PatchSet: 5
Gerrit-Owner: Steve Carlin <scar...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (816)
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com>
Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <scar...@cloudera.com>
Gerrit-Comment-Date: Tue, 25 Feb 2025 09:20:45 +0000
Gerrit-HasComments: Yes

Reply via email to