Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/22532 )
Change subject: IMPALA-13781: Fix "Median Diff %" for report_benchmark_results.py ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/22532/2/tests/benchmark/report_benchmark_results.py File tests/benchmark/report_benchmark_results.py: http://gerrit.cloudera.org:8080/#/c/22532/2/tests/benchmark/report_benchmark_results.py@349 PS2, Line 349: results, ref_results > nit: Renaming to current_impala_result vs ref_impala_result will help avoid When I look through the file, build_summary_header() is unique in its usage of "current_X" vs "ref_X". Most functions / classes use variables like X and ref_X. Sometimes they use X and base_X. If we switch, most of the file would need to change. I wish this code had unit tests. I'll file a JIRA for that. -- To view, visit http://gerrit.cloudera.org:8080/22532 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6f9da14bc7d5b6ef6a795b9024760f8cae77d72f Gerrit-Change-Number: 22532 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 25 Feb 2025 19:05:26 +0000 Gerrit-HasComments: Yes
