Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10513 )
Change subject: IMPALA-6933: Avoids db name collisions for Kudu tests ...................................................................... Patch Set 1: We had a long out of band discussion about this and agreed PS1 is incomplete. We feel a quick fix to get this fully working should also include os.getpid(). A nice-to-have would be to move all this stuff into a Kudu-specific file and out of the top-level conftest. You might encounter difficulty finding a suitable place due to how pytest finds fixtures: they must be in a conftest.py or a file that matches "test*.py". kudu_test_suite.py matches neither, but you could change this by using https://docs.pytest.org/en/2.9.2/customize.html#confval-python_files -- To view, visit http://gerrit.cloudera.org:8080/10513 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7c2f8a35fec90ae0dabe80237d83954668b47f6e Gerrit-Change-Number: 10513 Gerrit-PatchSet: 1 Gerrit-Owner: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Comment-Date: Fri, 25 May 2018 18:37:46 +0000 Gerrit-HasComments: No