Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22554 )
Change subject: [WIP] IMPALA-13593: Enable event processor to consume ALTER_PARTITIONS events from metastore ...................................................................... Patch Set 1: (7 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22554/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/22554/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@2748 PS1, Line 2748: // the list of partition objects of alter operation, as parsed from the NotificationEvent line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/22554/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@2759 PS1, Line 2759: Preconditions.checkState(getEventType().equals(MetastoreEventType.ALTER_PARTITIONS)); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/22554/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@2830 PS1, Line 2830: "processing cannot continue. Issue an invalidate command to reset " + line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/22554/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@2859 PS1, Line 2859: Arrays.asList(getTPartitionSpecFromHmsPartition(msTbl_, partitionsAfter_.get(0))), line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/22554/1/tests/custom_cluster/test_events_custom_configs.py File tests/custom_cluster/test_events_custom_configs.py: http://gerrit.cloudera.org:8080/#/c/22554/1/tests/custom_cluster/test_events_custom_configs.py@1523 PS1, Line 1523: flake8: E261 at least two spaces before inline comment http://gerrit.cloudera.org:8080/#/c/22554/1/tests/custom_cluster/test_events_custom_configs.py@1535 PS1, Line 1535: = flake8: E712 comparison to True should be 'if cond is True:' or 'if cond:' http://gerrit.cloudera.org:8080/#/c/22554/1/tests/custom_cluster/test_events_custom_configs.py@1545 PS1, Line 1545: = flake8: E712 comparison to True should be 'if cond is True:' or 'if cond:' -- To view, visit http://gerrit.cloudera.org:8080/22554 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I009a87ef5e2c331272f9e2d7a6342cc860e64737 Gerrit-Change-Number: 22554 Gerrit-PatchSet: 1 Gerrit-Owner: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Wed, 26 Feb 2025 21:29:28 +0000 Gerrit-HasComments: Yes
