Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/22553 )
Change subject: IMPALA-13803: Fix hiveserver2_protocol_version Values in Workload Management ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/22553/2/be/src/service/query-state-record.h File be/src/service/query-state-record.h: http://gerrit.cloudera.org:8080/#/c/22553/2/be/src/service/query-state-record.h@360 PS2, Line 360: std::string hiveserver2_protocol_version_formatted() const; > Would it make sense to also call this from client-request-state.cc where we That would be nice except the code in client-request-state.cc would have to construct a new QueryHandle so the code could construct a QueryStateExpanded using that QueryHandle. It's a lot of object creation to avoid a little bit of code duplication. Thus, I favor the code duplication. -- To view, visit http://gerrit.cloudera.org:8080/22553 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idd8121d4fbf7abe12d313f3314377db6f1ec017a Gerrit-Change-Number: 22553 Gerrit-PatchSet: 2 Gerrit-Owner: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Comment-Date: Wed, 26 Feb 2025 22:26:50 +0000 Gerrit-HasComments: Yes
