Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/22551 )
Change subject: IMPALA-13710: Fix Flaky Workload Management Custom Cluster Tests ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/22551/3/tests/util/workload_management.py File tests/util/workload_management.py: http://gerrit.cloudera.org:8080/#/c/22551/3/tests/util/workload_management.py@74 PS3, Line 74: > Make this a constant after L35. Done http://gerrit.cloudera.org:8080/#/c/22551/3/tests/util/workload_management.py@84 PS3, Line 84: option("MAX_ROW_SIZE", max > There should be no duplicate, but just in case, please assert that len(sql_ The sql could return 0 results though if the query is not yet available. Thus why the check len(sql_results.data) == 1 exists before declaring success. -- To view, visit http://gerrit.cloudera.org:8080/22551 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I38dad4819190fa44ca2933be9907d7f1273621e3 Gerrit-Change-Number: 22551 Gerrit-PatchSet: 4 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 26 Feb 2025 22:32:32 +0000 Gerrit-HasComments: Yes
