Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/22549 )
Change subject: IMPALA-13798: Cleanup host-level remote scratch dir on shutdown ...................................................................... Patch Set 3: (9 comments) http://gerrit.cloudera.org:8080/#/c/22549/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22549/2//COMMIT_MSG@7 PS2, Line 7: IMPALA-13798: Cleanup host-level remote scratch dir on shutdown > Maybe: "Cleanup host-level remote scratch dir on shutdown" Done http://gerrit.cloudera.org:8080/#/c/22549/2//COMMIT_MSG@9 PS2, Line 9: cleanup > cleanup of Done http://gerrit.cloudera.org:8080/#/c/22549/2//COMMIT_MSG@14 PS2, Line 14: chan > this behavior Done http://gerrit.cloudera.org:8080/#/c/22549/2//COMMIT_MSG@14 PS2, Line 14: permanently > or hostname changes. Done http://gerrit.cloudera.org:8080/#/c/22549/2//COMMIT_MSG@14 PS2, Line 14: ve this > removes Done http://gerrit.cloudera.org:8080/#/c/22549/2//COMMIT_MSG@20 PS2, Line 20: Changed the flag remote_scratch_cle > nit: remote_scratch_cleanup_on_start_stop Done http://gerrit.cloudera.org:8080/#/c/22549/2//COMMIT_MSG@21 PS2, Line 21: stop, s > either remove "also" or "as well" from this sentence. Done http://gerrit.cloudera.org:8080/#/c/22549/2//COMMIT_MSG@21 PS2, Line 21: ra > remove "to" Done http://gerrit.cloudera.org:8080/#/c/22549/2/be/src/runtime/tmp-file-mgr.h File be/src/runtime/tmp-file-mgr.h: http://gerrit.cloudera.org:8080/#/c/22549/2/be/src/runtime/tmp-file-mgr.h@209 PS2, Line 209: void CleanupAtShutdown(); > Maybe CleanupAtShutdown() is more clear? Done -- To view, visit http://gerrit.cloudera.org:8080/22549 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic8f446894afdf975630aef80a9d964a9a78d3b46 Gerrit-Change-Number: 22549 Gerrit-PatchSet: 3 Gerrit-Owner: Yida Wu <wydbaggio...@gmail.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com> Gerrit-Comment-Date: Thu, 27 Feb 2025 03:48:38 +0000 Gerrit-HasComments: Yes
