Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/22289 )
Change subject: IMPALA-12927: Support specifying format for reading JSON BINARY columns ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/22289/1/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java: http://gerrit.cloudera.org:8080/#/c/22289/1/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@572 PS1, Line 572: > I read that example, and propagating partition properties to the backend vi >Of course, this format determination can also be done at the backend, in which >case the jsonBinaryFormat_ in HdfsStorageDescriptor can be determined solely >based on metadata +1, I think that this would be the cleanest http://gerrit.cloudera.org:8080/#/c/22289/3/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java: http://gerrit.cloudera.org:8080/#/c/22289/3/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@570 PS3, Line 570: String specificFormat = : tbl_.getMetaStoreTable().getParameters().get(JSON_BINARY_FORMAT); > I briefly looked at the Hive code, and it does indeed merge table and SerDe +1, lets do it for serde properties for now and IMPALA-13748 should be solved in a separate patch -- To view, visit http://gerrit.cloudera.org:8080/22289 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idf61fa3afc0f33caa63fbc05393e975733165e82 Gerrit-Change-Number: 22289 Gerrit-PatchSet: 3 Gerrit-Owner: Zihao Ye <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zihao Ye <[email protected]> Gerrit-Comment-Date: Thu, 27 Feb 2025 13:31:03 +0000 Gerrit-HasComments: Yes
