Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22564 )
Change subject: IMPALA-13716 (Addendum): Simplify the call site of createSingleNodePlan() ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/22564/1/fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java File fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java: http://gerrit.cloudera.org:8080/#/c/22564/1/fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java@162 PS1, Line 162: /** : * Provided for a caller that does not supply a List of TupleIsNullPredicate. : */ : public PlanNode createSingleNodePlan(PlanNode root, : List<Expr> groupingExprs, List<Expr> inputPartitionExprs) throws ImpalaException { : return createSingleNodePlan(root, groupingExprs, inputPartitionExprs, : getTupleIsNullPreds(root)); > Thanks for the confirmation Michael! Done -- To view, visit http://gerrit.cloudera.org:8080/22564 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie10361f15db4c0eb2cf5ff5f4d0a28c612b1a930 Gerrit-Change-Number: 22564 Gerrit-PatchSet: 2 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Sat, 01 Mar 2025 01:28:58 +0000 Gerrit-HasComments: Yes
