Riza Suminto has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22565 )

Change subject: IMPALA-13814: test_iceberg_table_metrics fails in non-DFS builds
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/22565/1/tests/webserver/test_web_pages.py
File tests/webserver/test_web_pages.py:

http://gerrit.cloudera.org:8080/#/c/22565/1/tests/webserver/test_web_pages.py@1014
PS1, Line 1014: IS_HDFS or IS_OZONE
A more complete and reusable solution is to define function like 
is_support_block_location() in tests/util/filesystem_utils.py.
Do you mind adding it?



--
To view, visit http://gerrit.cloudera.org:8080/22565
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0c6d8a93e0a07cc680fac6e3f83218b853ca5e3
Gerrit-Change-Number: 22565
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <[email protected]>
Gerrit-Reviewer: Daniel Becker <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Comment-Date: Mon, 03 Mar 2025 13:00:54 +0000
Gerrit-HasComments: Yes

Reply via email to