Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22123
to look at the new patch set (#2).
Change subject: WIP: IMPALA-13486: Support MemBool backed by BufferPool in
parquet scanner
......................................................................
WIP: IMPALA-13486: Support MemBool backed by BufferPool in parquet scanner
ScratchBatch MemPools and data page pools are now backed by BufferPool
to reduce tcmalloc contention in the central free list.
Limitation:
Not change MT_DOP=0, i.e. HdfsScanNode, since
HdfsScanNode::ReturnReservationFromScannerThread() can't return the
reservation requested for the scanner thread. Reservation that
previously used by IO buffers might be used in the output RowBatch so
can't be returned. No such problem in MT_DOP>0 where
HdfsScanNode::ReturnReservationFromScannerThread() is not used.
TODO: calculate the min reservation based on the MemPools requirement.
TODO: test ORC scanner
Change-Id: I7cf0eac43fa98cb4cff66e5061f5bb561487d6ab
---
M be/src/exec/exec-node.h
M be/src/exec/hdfs-columnar-scanner.cc
M be/src/exec/hdfs-columnar-scanner.h
M be/src/exec/hdfs-scanner.h
M be/src/exec/parquet/hdfs-parquet-scanner.cc
M be/src/exec/parquet/hdfs-parquet-scanner.h
M be/src/exec/parquet/parquet-column-chunk-reader.cc
M be/src/exec/scratch-tuple-batch.h
M be/src/runtime/bufferpool/buffer-pool.h
M be/src/runtime/io/request-ranges.h
M be/src/runtime/mem-pool.cc
M be/src/runtime/mem-pool.h
M be/src/runtime/mem-tracker.cc
M be/src/runtime/mem-tracker.h
M be/src/runtime/row-batch.cc
M be/src/runtime/row-batch.h
16 files changed, 211 insertions(+), 56 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/23/22123/2
--
To view, visit http://gerrit.cloudera.org:8080/22123
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7cf0eac43fa98cb4cff66e5061f5bb561487d6ab
Gerrit-Change-Number: 22123
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
