Riza Suminto has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22569 )

Change subject: WIP IMPALA-13790: Fix test_wildcard_san_ssl / test_wildcard_ssl
......................................................................


Patch Set 4:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/22569/4/tests/custom_cluster/test_client_ssl.py
File tests/custom_cluster/test_client_ssl.py:

http://gerrit.cloudera.org:8080/#/c/22569/4/tests/custom_cluster/test_client_ssl.py@74
PS4, Line 74:                       .format(CERT_DIR, "ip4.impala.test"))
nit: format after close parenthesis, here and below.

                      ).format(CERT_DIR, "ip4.impala.test")


http://gerrit.cloudera.org:8080/#/c/22569/4/tests/custom_cluster/test_client_ssl.py@258
PS4, Line 258: if host: shell_options.extend(["-i", host])
nit: break line after colon, here and others above.



--
To view, visit http://gerrit.cloudera.org:8080/22569
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieedf682d06bdb6f8f68a5f77e41175e895b77ca9
Gerrit-Change-Number: 22569
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Laszlo Gaal <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Comment-Date: Tue, 04 Mar 2025 18:57:47 +0000
Gerrit-HasComments: Yes

Reply via email to