Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/22561 )
Change subject: IMPALA-13546: Fix Flaky JWT Unit Tests ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/22561/3/fe/src/test/java/org/apache/impala/customcluster/JwtHttpTest.java File fe/src/test/java/org/apache/impala/customcluster/JwtHttpTest.java: http://gerrit.cloudera.org:8080/#/c/22561/3/fe/src/test/java/org/apache/impala/customcluster/JwtHttpTest.java@621 PS3, Line 621: final Path log_file_path = logDir.resolve("impalad.ERROR"); > I just realized Path.resolve can also throw InvalidPathException. Good thought. I had the same thought while developing this change but decided against including it in the try...catch block after looking into the exception. The Javadoc on java.nio.file.Path says the resolve function throws InvalidPathException "if the path string cannot be converted to a Path". Since that is a string parsing issue, additional retries parsing the same broken string won't help. Thus, in that situation, I want the test to fail immediately instead of failing a guaranteed 10 times -- To view, visit http://gerrit.cloudera.org:8080/22561 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I48eea2b522b1834c92a8db14a0bdd63ca8c66c93 Gerrit-Change-Number: 22561 Gerrit-PatchSet: 3 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: gaurav singh <[email protected]> Gerrit-Comment-Date: Tue, 04 Mar 2025 19:22:42 +0000 Gerrit-HasComments: Yes
