Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22109 )
Change subject: IMPALA-13575: Calcite planner: Fix exception when null is in values clause ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/22109/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaValuesRel.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaValuesRel.java: http://gerrit.cloudera.org:8080/#/c/22109/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaValuesRel.java@111 PS5, Line 111: if (context.parentRowType_ != null) { > Should this check that the parent is actually a Project ? The value may be So that's not possible with the current code. The parentRowType is set to null for all other RelNodes. Only Project calls setParentRowType -- To view, visit http://gerrit.cloudera.org:8080/22109 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4e78fb0ed63b9525540ad537cfb7aabd8bbfe7ea Gerrit-Change-Number: 22109 Gerrit-PatchSet: 5 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Wed, 05 Mar 2025 17:59:01 +0000 Gerrit-HasComments: Yes
