Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21762 )
Change subject: IMPALA-13333: Limit memory estimation if PlanNode can spill ...................................................................... Patch Set 33: (2 comments) http://gerrit.cloudera.org:8080/#/c/21762/31/fe/src/main/java/org/apache/impala/planner/ResourceProfile.java File fe/src/main/java/org/apache/impala/planner/ResourceProfile.java: http://gerrit.cloudera.org:8080/#/c/21762/31/fe/src/main/java/org/apache/impala/planner/ResourceProfile.java@36 PS31, Line 36: // both are set. It is, however, not guaranteed to be <= maxMemReservationBytes_ if > Good catch on the mismatch between what the doc says and what the construct Thanks! http://gerrit.cloudera.org:8080/#/c/21762/31/fe/src/main/java/org/apache/impala/planner/ResourceProfileBuilder.java File fe/src/main/java/org/apache/impala/planner/ResourceProfileBuilder.java: http://gerrit.cloudera.org:8080/#/c/21762/31/fe/src/main/java/org/apache/impala/planner/ResourceProfileBuilder.java@110 PS31, Line 110: maxMemReservationBytes_, spillableBufferBytes_, maxRowBufferBytes_, > I don't like having the build logic separated between this class and the Re I moved this Preconditions to ResourceProfile contructor. I think ResourceBuilder.noReservation() and ResourceBuilder.invalid() should not change since they are referred in multiple places. It is also confusing to have noReservation() and invalid() in the fluent chain. -- To view, visit http://gerrit.cloudera.org:8080/21762 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I290c4e889d4ab9e921e356f0f55a9c8b11d0854e Gerrit-Change-Number: 21762 Gerrit-PatchSet: 33 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 05 Mar 2025 19:03:05 +0000 Gerrit-HasComments: Yes
