Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/22496 )
Change subject: IMPALA-13074: Add sink node to Web UI's graphical plan for DDL/DML queries ...................................................................... Patch Set 10: > IMO there's two ways to add testing. > 1. If we want tests for this change as well, first we should create the base > tests in IMPALA-13824 and then extend them in this change. > 2. After the submission of this change as-is, we will go forward with > IMPALA-13824, testing the modifications included in this change as well. > > What do you think? 3rd option is to put both IMPALA-13824 and IMPALA-13074 into a single patch. But I think the 1st approach makes the most sense. Anyway, the code LGTM! -- To view, visit http://gerrit.cloudera.org:8080/22496 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib2bd442f6499efde7406d87c2b1fd1b46a45381b Gerrit-Change-Number: 22496 Gerrit-PatchSet: 10 Gerrit-Owner: Daniel Vanko <dva...@cloudera.com> Gerrit-Reviewer: Daniel Vanko <dva...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Noemi Pap-Takacs <npaptak...@cloudera.com> Gerrit-Reviewer: Surya Hebbar <sheb...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Thu, 13 Mar 2025 14:19:41 +0000 Gerrit-HasComments: No
