Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10529 )
Change subject: IMPALA-6990: TestClientSsl.test_tls_v12 failing due to Python SSL error ...................................................................... Patch Set 2: (2 comments) > (2 comments) > > I wrote a comment on the JIRA upstream. > > I think the easier thing to do is to check Python version and skip > if you're using a too-old Python, with an explanation. Possibly add > a second copy of the test with the flag changes you suggest. > > But, regardless, I still don't quite understand whether the test > was just failing silently before or something fundamentally broke. I just realized that the test wasn't running before at all since all non-RHEL7 systems that we use for testing don't have OpenSSL 1.0.1+, which is the minimum required version for TLSv1.2. I updated the patch to skip this specific test if we don't have an up-to-date Python that supports the client using TLSv1.2. http://gerrit.cloudera.org:8080/#/c/10529/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10529/2//COMMIT_MSG@42 PS2, Line 42: which does not force the use of specific ciphers, so we get away without > What doesn't force the user of ciphers? Actually, I've found a flaw in my reasoning, I didn't realize but this test was being skipped on older-than-RHEL7-systems due to them having older versions of OpenSSL, that don't support TLSv1.2. So, the ciphers had nothing to do with it and I've removed this para. http://gerrit.cloudera.org:8080/#/c/10529/2//COMMIT_MSG@49 PS2, Line 49: least unblock our builds while we can upgrade the AMIs for RHEL7. This > RHEL7 just doesn't ship a newer Python based on my quick check with Docker. Makes sense. I've skipped the test unless a TLSv1.2 compatible version of Python is detected. -- To view, visit http://gerrit.cloudera.org:8080/10529 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I92c66ecaeb94b0c83ee6f1396c082709c21b3187 Gerrit-Change-Number: 10529 Gerrit-PatchSet: 2 Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Comment-Date: Tue, 29 May 2018 22:55:20 +0000 Gerrit-HasComments: Yes
