Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10528 )
Change subject: IMPALA-7090: Limit the size of expr created by EqualityDisjunctsToInRule ...................................................................... Patch Set 2: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/10528/1/fe/src/main/java/org/apache/impala/rewrite/EqualityDisjunctsToInRule.java File fe/src/main/java/org/apache/impala/rewrite/EqualityDisjunctsToInRule.java: http://gerrit.cloudera.org:8080/#/c/10528/1/fe/src/main/java/org/apache/impala/rewrite/EqualityDisjunctsToInRule.java@82 PS1, Line 82: else if (otherPred instanceof InPredicate && !((InPredicate) otherPred).isNotIn() > While more fault tolerance is often good, I don't think we want an unoptimi As we add more rules and independently change analysis for expressions, I expect unforeseen cases like this to be more common. Currently, if such a case comes up (as without this change), the end user needs to turn off rewrites while waiting for a bug fix. Do we have other cases where optimizations are not applied, but the query is run (with a warning)? http://gerrit.cloudera.org:8080/#/c/10528/2/fe/src/test/java/org/apache/impala/analysis/ExprRewriterTest.java File fe/src/test/java/org/apache/impala/analysis/ExprRewriterTest.java: http://gerrit.cloudera.org:8080/#/c/10528/2/fe/src/test/java/org/apache/impala/analysis/ExprRewriterTest.java@172 PS2, Line 172: /** co nit: reformat this comment: /** * Construct an in-list: string_col in (offset ... offset + length) */ ... to be consistent with other single line method comments. -- To view, visit http://gerrit.cloudera.org:8080/10528 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie40c3210271a9e3c7f1b2b869a8c2ec8bacaa72a Gerrit-Change-Number: 10528 Gerrit-PatchSet: 2 Gerrit-Owner: Tianyi Wang <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Wed, 30 May 2018 01:02:59 +0000 Gerrit-HasComments: Yes
