Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/22588 )
Change subject: IMPALA-13812: Fail query for certain errors related to AI functions ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/22588/3/testdata/workloads/functional-query/queries/QueryTest/ai_generate_text_exprs.test File testdata/workloads/functional-query/queries/QueryTest/ai_generate_text_exprs.test: http://gerrit.cloudera.org:8080/#/c/22588/3/testdata/workloads/functional-query/queries/QueryTest/ai_generate_text_exprs.test@8 PS3, Line 8: from keystor > Can we fix the original error message and add a space between 'from' and 'k Done http://gerrit.cloudera.org:8080/#/c/22588/3/testdata/workloads/functional-query/queries/QueryTest/ai_generate_text_exprs.test@59 PS3, Line 59: ==== > Can we also move these two queries to this test file and change it to CATCH Done http://gerrit.cloudera.org:8080/#/c/22588/3/tests/query_test/test_exprs.py File tests/query_test/test_exprs.py: http://gerrit.cloudera.org:8080/#/c/22588/3/tests/query_test/test_exprs.py@138 PS3, Line 138: table_format = vector.get_value('table_format') > Suggest only running the test for table_format parquet as it doesn't depend Done -- To view, visit http://gerrit.cloudera.org:8080/22588 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I639e48e64d62f7990cf9a3c35a59a0ee3a2c64e0 Gerrit-Change-Number: 22588 Gerrit-PatchSet: 4 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Mon, 10 Mar 2025 17:19:01 +0000 Gerrit-HasComments: Yes
