Mihaly Szjatinya has posted comments on this change. ( http://gerrit.cloudera.org:8080/22643 )
Change subject: IMPALA-13877: Fix missing stats time in TestLastDdlTimeUpdate ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/22643/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22643/1//COMMIT_MSG@6 PS1, Line 6: : IMPALA-13877: Fix missing stats time in TestLastDdlTimeUpdate > nit: Title can be shorter: Ack http://gerrit.cloudera.org:8080/#/c/22643/1//COMMIT_MSG@9 PS1, Line 9: This patch fixes broken tests afte > nit: Description can be more elaborate. Ack http://gerrit.cloudera.org:8080/#/c/22643/1/tests/metadata/test_last_ddl_time_update.py File tests/metadata/test_last_ddl_time_update.py: http://gerrit.cloudera.org:8080/#/c/22643/1/tests/metadata/test_last_ddl_time_update.py@196 PS1, Line 196: # change format of > I think you should restore the original drop stats query and change this to Yeah, that's better, also had to add similar expect_stat_time_set() to fix the consequent assert -- To view, visit http://gerrit.cloudera.org:8080/22643 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I99e37b9168c2c79a913ca0c717cad1ed9253100a Gerrit-Change-Number: 22643 Gerrit-PatchSet: 3 Gerrit-Owner: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 19 Mar 2025 20:30:20 +0000 Gerrit-HasComments: Yes
