Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/22626 )
Change subject: IMPALA-13864: Implement ImpylaHS2ResultSet.exec_summary ...................................................................... Patch Set 4: (8 comments) http://gerrit.cloudera.org:8080/#/c/22626/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22626/3//COMMIT_MSG@15 PS3, Line 15: by > Done Done http://gerrit.cloudera.org:8080/#/c/22626/3/shell/impala_client.py File shell/impala_client.py: http://gerrit.cloudera.org:8080/#/c/22626/3/shell/impala_client.py@141 PS3, Line 141: if not summary.nodes or len(summary.nodes) <= idx: > Make sense. Done. On second thought, it should be an assertion assert len(sumary.nodes) > idx. The reason being that before this change, accessing summary.nodex[idx] would throw an error if idx was out of range, but with this change, it will silently return. I think it best to let the caller know they have their index wrong. http://gerrit.cloudera.org:8080/#/c/22626/3/tests/beeswax/impala_beeswax.py File tests/beeswax/impala_beeswax.py: http://gerrit.cloudera.org:8080/#/c/22626/3/tests/beeswax/impala_beeswax.py@398 PS3, Line 398: return None > Done Done http://gerrit.cloudera.org:8080/#/c/22626/3/tests/common/impala_connection.py File tests/common/impala_connection.py: http://gerrit.cloudera.org:8080/#/c/22626/3/tests/common/impala_connection.py@113 PS3, Line 113: > Unfortunately, start-impala-cluster.py does not work if I do that. Ah, that explains it. I withdraw the comment. http://gerrit.cloudera.org:8080/#/c/22626/3/tests/common/impala_connection.py@305 PS3, Line 305: > Done Done http://gerrit.cloudera.org:8080/#/c/22626/3/tests/common/impala_connection.py@487 PS3, Line 487: t, user > Done Done http://gerrit.cloudera.org:8080/#/c/22626/3/tests/custom_cluster/test_executor_groups.py File tests/custom_cluster/test_executor_groups.py: http://gerrit.cloudera.org:8080/#/c/22626/3/tests/custom_cluster/test_executor_groups.py@a1053 PS3, Line 1053: > Yes. Custom cluster test will recreate clients on each for each test method Thanks! http://gerrit.cloudera.org:8080/#/c/22626/3/tests/custom_cluster/test_executor_groups.py@992 PS3, Line 992: self.hs2_client.set_configuration_option(k, v) > Done Done -- To view, visit http://gerrit.cloudera.org:8080/22626 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7d88f78e58eeda29ce21e7828884c7a129d7efe6 Gerrit-Change-Number: 22626 Gerrit-PatchSet: 4 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 19 Mar 2025 23:14:02 +0000 Gerrit-HasComments: Yes
