Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10523 )
Change subject: IMPALA-7082: Show human readable size in query backend page ...................................................................... Patch Set 4: Code-Review+1 This looks fine to me. If we end up doing a lot of this, we'll want to have a javascript unit test framework, but I don't think we're there yet :) I'd give a +2, but I think we're currently trying to not add more things until the builds stabilize a bit more. (See e-mails from Thomas on the dev list.) -- To view, visit http://gerrit.cloudera.org:8080/10523 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I04afb4091bb8b6bc9dedfeceaf9284a8c65b16a1 Gerrit-Change-Number: 10523 Gerrit-PatchSet: 4 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Comment-Date: Wed, 30 May 2018 03:48:55 +0000 Gerrit-HasComments: No
