Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/9986 )
Change subject: IMPALA-3307: Add support for IANA time-zone db ...................................................................... Patch Set 10: > > > > > Uploaded patch set 9. > > > > > > > > Patch -set 9 contains the following changes: > > > > - Added a full timezone db to testdata/tzdb. > > > > - End-to-end tests and BE-tests were changed to use this > > timezone > > > > db. This was necessary because some timezone-tests were > failing > > > on > > > > older jenkins workers that had an older tzdata package > > installed. > > > > > > It might be a good idea to store the timezone-db files in one > > .tar > > > file and extract them before running the tests. What do you > > think? > > > > I agree, .taring or compressing the tz db would be much better, > if > > it does not make the code too complicated. Having less file would > > make the review more readable, and would also make the tz db > > consume much less space on hdfs, as the many small files will be > > rounded up to hdfs block size. > > Extracting files from a .tar file can be tricky. Probably we would > have to add libtar library to the native-toolchain to handle .tar > files. > > Alternatively we can store timezone files in a JAR archive instead. > The BE can call into the java FE to extract files from it. Tim, Dan, what do you think? -- To view, visit http://gerrit.cloudera.org:8080/9986 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I93c1fbffe81f067919706e30db0a34d0e58e7e77 Gerrit-Change-Number: 9986 Gerrit-PatchSet: 10 Gerrit-Owner: Attila Jeges <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 30 May 2018 15:34:20 +0000 Gerrit-HasComments: No
