Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22333 )
Change subject: IMPALA-13903: Enable hooks in test framework to run parser tests for Calcite planner ...................................................................... Patch Set 5: (14 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22333/5/fe/src/test/java/org/apache/impala/analysis/ParserTest.java File fe/src/test/java/org/apache/impala/analysis/ParserTest.java: http://gerrit.cloudera.org:8080/#/c/22333/5/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@282 PS5, Line 282: parserFixture_.TestInsertAndCtasHints("t", "t", hintStyle, "noshuffle", "noshuffle"); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/22333/5/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@285 PS5, Line 285: parserFixture_.TestInsertAndCtasHints("t(a, b) partition(x, y)", "t partitioned by(x, y)", line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/22333/5/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@287 PS5, Line 287: parserFixture_.TestInsertAndCtasHints("t(a, b) partition(x, y)", "t partitioned by(x, y)", line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/22333/5/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@402 PS5, Line 402: parserFixture_.TestJoinHints("select * from functional.alltypes a join /* comment */" + line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/22333/5/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@406 PS5, Line 406: parserFixture_.TestInsertStmtHints("insert %s into t(a, b) partition(x, y) %s select 1", line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/22333/5/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@408 PS5, Line 408: parserFixture_.TestCtasHints("create /* comment */ table t partitioned by (x, y) as select 1", line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/22333/5/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@410 PS5, Line 410: parserFixture_.TestSelectListHints("select /* -- +straight_join */ * from functional.alltypes", line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/22333/5/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@412 PS5, Line 412: parserFixture_.TestSelectListHints("select /* abcdef +straight_join */ * from functional.alltypes", line too long (103 > 90) http://gerrit.cloudera.org:8080/#/c/22333/5/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@414 PS5, Line 414: parserFixture_.TestSelectListHints("select \n-- abcdef +straight_join\n * from functional.alltypes", line too long (104 > 90) http://gerrit.cloudera.org:8080/#/c/22333/5/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@416 PS5, Line 416: parserFixture_.TestSelectListHints("select \n-- /*+straight_join\n * from functional.alltypes", line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/22333/5/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@420 PS5, Line 420: parserFixture_.TestSelectListHints("select /*\n +straight_join */ * from functional.alltypes", line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/22333/5/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@422 PS5, Line 422: parserFixture_.TestSelectListHints("select /* +straight_join \n*/ * from functional.alltypes", line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/22333/5/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@424 PS5, Line 424: parserFixture_.TestSelectListHints("select /* +straight_\njoin */ * from functional.alltypes", line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/22333/5/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@436 PS5, Line 436: parserFixture_.TestSelectListHints("select /* +straight_join, ,, */ * from functional.alltypes", line too long (100 > 90) -- To view, visit http://gerrit.cloudera.org:8080/22333 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibbd272f9c2b3ecbb87fa19caccf4fc51a25fea1b Gerrit-Change-Number: 22333 Gerrit-PatchSet: 5 Gerrit-Owner: Steve Carlin <scar...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Comment-Date: Wed, 26 Mar 2025 17:23:10 +0000 Gerrit-HasComments: Yes
