Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10060 )
Change subject: IMPALA-5216: Make admission control queuing async ...................................................................... Patch Set 16: > - GetOperationStatus() after rejection should show reason. > => GetOperationStatus contains the operation state and the status > message. Unfortunately for a CANCELLED status the message is empty. > Instead we can take care of this coverage after IMPALA-1262 where > we can check for operation state to verify this scenario. I assume the CANCELLED case is covered by your sleeps. Is the GetOperationStatus() (or beeswax equivalent) after rejection/timeout covered by some test? (Presumably the admission controller test?) -- To view, visit http://gerrit.cloudera.org:8080/10060 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I989cf5b259afb8f5bc5c35590c94961c81ce88bf Gerrit-Change-Number: 10060 Gerrit-PatchSet: 16 Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 30 May 2018 18:35:26 +0000 Gerrit-HasComments: No
