Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10531 )
Change subject: IMPALA-7091: Address NullPointerException in HBaseTable.getRegionSize(). ...................................................................... Patch Set 1: (1 comment) I think handling the null is the right thing to do. It bothers me a bit that we got the list of HRegionLocation from HBase and then one of these calls fails. http://gerrit.cloudera.org:8080/#/c/10531/1/fe/src/main/java/org/apache/impala/catalog/HBaseTable.java File fe/src/main/java/org/apache/impala/catalog/HBaseTable.java: http://gerrit.cloudera.org:8080/#/c/10531/1/fe/src/main/java/org/apache/impala/catalog/HBaseTable.java@711 PS1, Line 711: This is copied from org.apache.hadoop.hbase.client.HTable in HBase 0.95 This is where the HRegionLocation is coming from, maybe this needs to be updated for the new HBase? We had a TODO here, but we removed it in IMPALA-4082. -- To view, visit http://gerrit.cloudera.org:8080/10531 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I02f06daf69e7f7e97c9ecc13997147530c2f9d3f Gerrit-Change-Number: 10531 Gerrit-PatchSet: 1 Gerrit-Owner: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Comment-Date: Wed, 30 May 2018 18:53:03 +0000 Gerrit-HasComments: Yes
