Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22699 )
Change subject: IMPALA-13906: Change TestQueryConcurrency to regular query_test ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/22699/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22699/3//COMMIT_MSG@18 PS3, Line 18: > nit: possible line break Done http://gerrit.cloudera.org:8080/#/c/22699/3/tests/query_test/test_query_concurrency.py File tests/query_test/test_query_concurrency.py: http://gerrit.cloudera.org:8080/#/c/22699/3/tests/query_test/test_query_concurrency.py@72 PS3, Line 72: ine s > Should we declare this as a constant, or possibly comment what it stands fo Not used anywhere else, so it is OK not to have it as constant. Added comment instead. -- To view, visit http://gerrit.cloudera.org:8080/22699 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia33f7c0a36df0f1922055902974ce3e0c2fb6fdb Gerrit-Change-Number: 22699 Gerrit-PatchSet: 4 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Fri, 28 Mar 2025 16:07:06 +0000 Gerrit-HasComments: Yes
