Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10510 )
Change subject: IMPALA-5552: Add support for authorized proxy groups ...................................................................... Patch Set 7: (5 comments) http://gerrit.cloudera.org:8080/#/c/10510/5/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/10510/5/be/src/service/impala-server.cc@406 PS5, Line 406: thorized_proxy_user_config or FLAGS_authorized_proxy_group_config > can be specific to to the authorized_proxy_config for which this method was I initially did that with lambda: https://gerrit.cloudera.org/c/10510/2/be/src/service/impala-server.cc#323. Let me know what you think about it and I can use the old code back. http://gerrit.cloudera.org:8080/#/c/10510/5/be/src/service/impala-server.cc@412 PS5, Line 412: st string& config: proxy_confi > if ws is included around a group or user string, e.g., " * ", will (and s Make sense I'll update it. http://gerrit.cloudera.org:8080/#/c/10510/5/be/src/service/impala-server.cc@416 PS5, Line 416: > can use a literal pair constructor: { ... } Done http://gerrit.cloudera.org:8080/#/c/10510/5/be/src/service/impala-server.cc@1383 PS5, Line 1383: if (user == "*" | > its an error, no need to wrap. Done http://gerrit.cloudera.org:8080/#/c/10510/5/fe/src/main/java/org/apache/impala/service/JniFrontend.java File fe/src/main/java/org/apache/impala/service/JniFrontend.java: http://gerrit.cloudera.org:8080/#/c/10510/5/fe/src/main/java/org/apache/impala/service/JniFrontend.java@635 PS5, Line 635: startsWith > This makes the error messages in the security package part of the api. Is t Unfortunately there's no way to do this at the moment. I agree this is very ugly. This is another example in Impala that relies on the same exact exception message: https://github.com/apache/impala/blob/e9bd917a218b5e1717fced983f70f64850c6e02f/fe/src/main/java/org/apache/impala/util/RequestPoolService.java#L302 The source in Hadoop API: https://github.com/apache/hadoop/blob/47c31ff16b452d47afc6ffc1cf936ac2de9b788d/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/Groups.java#L198-L200 -- To view, visit http://gerrit.cloudera.org:8080/10510 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6953f89c293b06b72f523b11802232133d9d6cbb Gerrit-Change-Number: 10510 Gerrit-PatchSet: 7 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Greg Rahn <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Wed, 30 May 2018 18:55:41 +0000 Gerrit-HasComments: Yes
