Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22705 )
Change subject: IMPALA-13920: Allow running minicluster with Java 17 ...................................................................... Patch Set 19: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/22705/19/bin/run-all-tests.sh File bin/run-all-tests.sh: http://gerrit.cloudera.org:8080/#/c/22705/19/bin/run-all-tests.sh@289 PS19, Line 289: -javaagent:${JAMM_JAR} > nit: Before this patch, this will carries to EE_TEST and others after FE_TE Yes, I think that's actually a good change for isolation. The Impala cluster shouldn't need this option specified in JAVA_TOOL_OPTIONS. -- To view, visit http://gerrit.cloudera.org:8080/22705 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If58b64a21d14a4a55b12dfe9ea0b9c3d5fe9c9cf Gerrit-Change-Number: 22705 Gerrit-PatchSet: 19 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Fri, 04 Apr 2025 17:49:53 +0000 Gerrit-HasComments: Yes
